Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the image pull policy on the container orchestration #15385

Merged
merged 9 commits into from
Aug 22, 2022
Merged

Set the image pull policy on the container orchestration #15385

merged 9 commits into from
Aug 22, 2022

Conversation

gfeldman
Copy link
Contributor

@gfeldman gfeldman commented Aug 6, 2022 •
edited
Loading

Set the image pull policy on the container orchestration container to the main job image pull policy. Addresses issue

What

This sets the container orchestrator image pull policy to be consistent with the main job pull policy for those clusters that have restrictions on pull policy settings.

How

Set the image pull policy on the container orchestration container to the main job image pull policy.

Recommended reading order

  1. Worker.java - specifically ContainerOrchestratorConfig
  2. AsyncOrchestratorPodProcess.java

🚨 User Impact 🚨

No user impact

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Aug 6, 2022
@marcosmarxm
Copy link
Member

@gfeldman can you run ./gradlew format to correct the formatting?

@gfeldman
Copy link
Contributor Author

gfeldman commented Aug 9, 2022

@gfeldman can you run ./gradlew format to correct the formatting?

Will do

@gfeldman gfeldman force-pushed the guy/13686-add-image-pull-policy-to-container-orchestrator branch from 76fdfef to 81a2619 Compare August 9, 2022 07:21
@gfeldman
Copy link
Contributor Author

gfeldman commented Aug 9, 2022

I ran SUB_BUILD=PLATFORM ./gradlew format it still looks like it's removing spaces

@marcosmarxm marcosmarxm self-assigned this Aug 11, 2022
benmoriceau
benmoriceau reviewed Aug 11, 2022
View reviewed changes
...-integration/java/io/airbyte/workers/process/AsyncOrchestratorPodProcessIntegrationTest.java Outdated Show resolved Hide resolved
...-integration/java/io/airbyte/workers/process/AsyncOrchestratorPodProcessIntegrationTest.java Outdated
@@ -97,46 +98,51 @@ public static void init() throws Exception {

@Test
public void test() throws InterruptedException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this review but we should rename that, test is not very meaningful

@gfeldman gfeldman force-pushed the guy/13686-add-image-pull-policy-to-container-orchestrator branch from e043502 to 7338246 Compare August 13, 2022 15:00
@gfeldman gfeldman requested a review from davinchia August 13, 2022 15:03
davinchia
davinchia approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one nit.

@gfeldman gfeldman force-pushed the guy/13686-add-image-pull-policy-to-container-orchestrator branch from d468d27 to 6a42f44 Compare August 18, 2022 07:12
@davinchia
Copy link
Contributor

@marcosmarxm I think this is good to go

@marcosmarxm marcosmarxm merged commit 6901563 into airbytehq:master Aug 22, 2022
@evantahler evantahler mentioned this pull request Aug 22, 2022
Merged
rodireich pushed a commit that referenced this pull request Aug 25, 2022
@gfeldman @rodireich
Set the image pull policy on the container orchestration (#15385)
6565544 
* Set the image pull policy on the container orchestration container to the main job image pull policy

* make sure pod have different names

* fix naming

* formatting

* adding container info and moving fields into it

* formatting

* make image fake image on state manager test

* logging a warning instead of a hard exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

Assignees

@marcosmarxm marcosmarxm

Labels
area/platform issues related to the platform area/worker Related to worker community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gfeldman @marcosmarxm @davinchia @benmoriceau @octavia-squidington-iii